fix: demo relative path also need to share #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PeachScript
reviewed
Aug 23, 2024
| if (key !== entryFileName && !isRelativePath(key)) { | ||
| if (shareDepsMap[key]) { | ||
| demoDepsMap[demo.id][key] = shareDepsMap[key]; | ||
| if (key !== entryFileName) { |
There was a problem hiding this comment.
这里改完似乎前后不等价，修改前 entryFileName 会进 demoDepsMap，修改后不会了，但应该修改前是不符合预期的
Ps: 感觉这里的逻辑看起来有点吃力，可能前面 PR 忘了，建议补点注释
There was a problem hiding this comment.
对 ,修改前有问题~, 好的, 我后面补充上来~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？/ What is the nature of this change?
🔗 相关 Issue / Related Issue
💡 需求背景和解决方案 / Background or solution
demo 共享 deps, 引入相对路径时, 忽略了相对路径可能最终 resolve 的 path 是一致的, 对于这种情况也需要共享, 否则依赖引入会缺失.
📝 更新日志 / Changelog